2019 02 08 sor f op6 no2 edits 2 #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
small fix
Added link to ly2video rendering
Summary: Ideally, these would automatically save and restore the MIDI instruments. For now, we'll just use manual `\set Staff.midiInstrument` directives in the score.
Summary: As in eb0fec4.
Fixed octava from bar 10 until end. Fixed rest positions and full bar rests. Use default font size. Alexander Brock has already approved the changes.
Prepare PR 1041 for publication, magic flute changes only.
Prep PR 1043, 2nd movement to KV488
Prep pull request 1040, new ID 2240
glenl
reviewed
Feb 27, 2019
| d8 c b,4 c | | ||
| d2 d4 | | ||
| g,4 g f! | | ||
| <g, d>4 g f! | |
Owner
There was a problem hiding this comment.
Existing code looks correct in this measure.
Owner
|
Devin - I just got around to reviewing this. I agree with all your edits but one (marked in code.) Note all the other files involved in this PR, if you submit this to MutopiaProject, please make sure it is a single file pull request. Thanks for the repairs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Glen,
I want to check this a little bit more, since I did this off the top of my head, but FYI.
Best,
Devin